Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1383 - CLI project args #1384

Merged
merged 3 commits into from
Nov 28, 2019
Merged

#1383 - CLI project args #1384

merged 3 commits into from
Nov 28, 2019

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented Nov 28, 2019 •
edited
Loading

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

Description:
Some refactor to know how to and new test case, specific for the issue.

Thanks

@Jeckerson Jeckerson added this to the 4.0.0 milestone Nov 28, 2019
@Jeckerson Jeckerson self-assigned this Nov 28, 2019
@Jeckerson Jeckerson changed the base branch from master to 4.0.x November 28, 2019 22:58
@sergeyklay
Copy link
Contributor

sergeyklay commented Nov 28, 2019 •
edited
Loading

What do you think about integration with https://github.com/phalcon/cli-options-parser (to not duplicate approaches and don't reinvent wheel)

@Jeckerson
Copy link
Member Author

For sure, after v4 release it will be done. Also, same will be with migrations.

@codecov
Copy link

codecov bot commented Nov 28, 2019 •
edited
Loading

Codecov Report

Merging #1384 into 4.0.x will increase coverage by 0.04%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             4.0.x   #1384      +/-   ##
==========================================
+ Coverage     3.51%   3.55%   +0.04%     
  Complexity    1133    1133              
==========================================
  Files          115     115              
  Lines         4755    4757       +2     
==========================================
+ Hits           167     169       +2     
  Misses        4588    4588
Impacted Files Coverage Δ Complexity Δ
src/Commands/Command.php 34.56% <71.42%> (+0.81%) 68 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 986a93d...0bdc853. Read the comment docs.

@Jeckerson
Copy link
Member Author

#1385

@Jeckerson Jeckerson merged commit 8cd4e59 into 4.0.x Nov 28, 2019
@Jeckerson Jeckerson deleted the fix/#1383-cli-project-args branch November 28, 2019 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyklay sergeyklay sergeyklay approved these changes

@niden niden Awaiting requested review from niden

@CameronHall CameronHall Awaiting requested review from CameronHall

@ruudboon ruudboon Awaiting requested review from ruudboon

Assignees

@Jeckerson Jeckerson

Labels
Testing
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Jeckerson @sergeyklay